feat: set up gen ai inference attributes for foundational text models #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiyuan-he
force-pushed
the
gen-ai-support
branch
from
fc898fb
to
6cd9bcc
Compare
yiyuan-he
changed the title
yiyuan-he
force-pushed
the
gen-ai-support
branch
from
eafdabb
to
842f9c9
Compare
yiyuan-he
changed the title
yiyuan-he
commented
Oct 30, 2024
aws-distro-opentelemetry-node-autoinstrumentation/src/patches/aws/services/bedrock.ts
Show resolved
Hide resolved
mxiamxia
reviewed
Oct 31, 2024
aws-distro-opentelemetry-node-autoinstrumentation/src/patches/aws/services/bedrock.ts
Outdated
Show resolved
Hide resolved
mxiamxia
reviewed
Oct 31, 2024
aws-distro-opentelemetry-node-autoinstrumentation/src/patches/aws/services/bedrock.ts
Show resolved
Hide resolved
yiyuan-he
commented
Oct 31, 2024
aws-distro-opentelemetry-node-autoinstrumentation/src/patches/aws/services/bedrock.ts
Show resolved
Hide resolved
mxiamxia
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adding auto-instrumentation support for GenAI inference parameters.
The following foundational text models are supported:
Full list can be found here. Note, we do not support Stability AI models at this time since they are focused on text to image.
New inference parameter attributes added according to OpenTelemetry Semantic Conventions for GenAI attributes:
gen_ai.request.max_tokensgen_ai.request.temperaturegen_ai.request.top_pgen_ai.response.finish_reasonsgen_ai.usage.input_tokensgen_ai.usage.output_tokensTest Plan:
Set up sample app to make Bedrock Runtime
InvokeModelAPI calls to the supported foundational models and verified the auto-instrumentation attributes.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.